[Fix #9934] Fix configuration loading to not raise an error for an obsolete ruby version that is overridden #10112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a configuration file inherits another that sets
TargetRubyVersion
to an obsolete version, a config validation error is raised by RuboCop. This causes an irreconcilable issue if the inherited config is shared with other projects or not editable (from upstream, etc.).In order to fix this, the target ruby version check is moved to happen after all the config resolution steps have completed, so at that point, all the various
TargetRubyVersion
values have been collapsed into a single value that can be verified. This allows for any number of complicated inheritence chains without causing issues.Fixes #9934.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.